ctubbsii commented on a change in pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332#discussion_r737819101
##########
File path: core/src/main/java/org/apache/accumulo/core/util/CleanUp.java
##########
@@ -47,10 +49,17 @@
/**
* kills all threads created by internal Accumulo singleton resources. After
this method is
* called, no Connector will work in the current classloader.
+ *
+ * @param conn
+ * If available, Connector object to close resources on. Will
accept null otherwise.
*/
- public static void shutdownNow() {
+ public static void shutdownNow(Connector conn) {
Review comment:
Should be fine since this isn't public API.
##########
File path: core/src/main/java/org/apache/accumulo/core/util/CleanUp.java
##########
@@ -21,6 +21,8 @@
import java.util.Set;
import org.apache.accumulo.core.client.AccumuloClient;
+import org.apache.accumulo.core.client.Connector;
+import org.apache.accumulo.core.clientImpl.ConnectorImpl;
Review comment:
I think these are deprecated. You may need to avoid imports of these to
avoid unnecessary warnings about deprecated classes being referenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
