keith-turner commented on a change in pull request #297:
URL: https://github.com/apache/accumulo-website/pull/297#discussion_r738572325
##########
File path: _posts/release/2020-01-19-accumulo-2.1.0.md
##########
@@ -62,9 +62,13 @@ Significant changes were made to how Accumulo compacts files
in this release. S
The new compaction changes in this release can satisfy this use case while
doing a logarithmic amount of work.
-CompactionStrategy was deprecated in favor of new public APIs.
-See its [javadoc]({% jurl
org.apache.accumulo.tserver.compaction.CompactionStrategy %})
-for more information. Github tickets related to these changes: {% ghi 564 %}
{% ghi 1605 %} {% ghi 1609 %} {% ghi 1649 %} {% ghi %}
+CompactionStrategy was deprecated in favor of new public APIs.
CompactionStrategy was never public API as it
+used internal types and one of these types `FileRef` was removed in 2.1. Users
who have written a CompactionStrategy
+can replace `FileRef` with its replacement internal type `StoredTabletFile`
but this is not recommended. Since it is
+very likely that CompactionStrategy will be removed in a future release, any
work put into rewriting a CompactionStrategy
+will be lost. It is recommended that users implement CompactionSelector,
CompactionConfigurer, and CompactionPlanner instead. See
Review comment:
Could add a bit more about how configuring compaction strategies may
mean you miss out on benefits of new features.
```suggestion
will be lost. It is recommended that users implement CompactionSelector,
CompactionConfigurer, and CompactionPlanner instead. The new compaction
changes in 2.1 introduce new algorithms for optimally scheduling compactions
across multiple thread pools, configuring a deprecated compaction strategy may
result is missing out on the benefits of these new algorithms. See
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
