dlmarion commented on a change in pull request #2318:
URL: https://github.com/apache/accumulo/pull/2318#discussion_r739200715
##########
File path:
core/src/main/java/org/apache/accumulo/core/util/compaction/ExternalCompactionUtil.java
##########
@@ -191,29 +227,28 @@ private static ExternalCompactionId
getRunningCompactionId(HostAndPort compactor
* server context
* @return map of compactor and external compaction jobs
*/
- public static Map<HostAndPort,TExternalCompactionJob>
- getCompactionsRunningOnCompactors(ClientContext context) {
-
- final List<Pair<HostAndPort,Future<TExternalCompactionJob>>> running = new
ArrayList<>();
+ public static List<RunningCompaction>
getCompactionsRunningOnCompactors(ClientContext context) {
+ final List<RunningCompactionFuture> rcFutures = new ArrayList<>();
Review comment:
I think TExternalCompactionList and TExternalCompaction should contain
the same information as RunningCompaction. If not, I can look at making
RunningCompaction a Thrift object. I don't see anything that says that Thrift
supports a sorted map. Should be pretty easy to sort them in the Monitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
