keith-turner commented on a change in pull request #2337:
URL: https://github.com/apache/accumulo/pull/2337#discussion_r742080273
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
##########
@@ -763,7 +763,7 @@ public void run() {
log.trace("{} - binning {} mutations",
Thread.currentThread().getName(),
mutationsToSend.size());
addMutations(mutationsToSend);
- } catch (Exception e) {
+ } catch (Throwable e) {
updateUnknownErrors("Error processing mutation set", e);
Review comment:
>> It seems like the argument against this is that it may not work
therefore do not even make the attempt.
>
> I don't recognize my position in your portrayal here.
That was a synthesis of how I felt after reading lots of comments around
this. However the statement is not grounded in any fact and throwing it in was
not productive. Please forgive the mistake and ignore the comment.
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
##########
@@ -763,7 +763,7 @@ public void run() {
log.trace("{} - binning {} mutations",
Thread.currentThread().getName(),
mutationsToSend.size());
addMutations(mutationsToSend);
- } catch (Exception e) {
+ } catch (Throwable e) {
updateUnknownErrors("Error processing mutation set", e);
Review comment:
>> It seems like the argument against this is that it may not work
therefore do not even make the attempt.
>
> I don't recognize my position in your portrayal here.
That was a synthesis of how I felt after reading lots of comments around
this. However the statement is not grounded in any fact and throwing it in was
not productive. Please forgive the mistake and ignore the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
