milleruntime commented on a change in pull request #2347:
URL: https://github.com/apache/accumulo/pull/2347#discussion_r745036356
##########
File path:
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/system/SortedMapIterator.java
##########
@@ -121,4 +143,9 @@ public void init(SortedKeyValueIterator<Key,Value> source,
Map<String,String> op
IteratorEnvironment env) throws IOException {
throw new UnsupportedOperationException();
}
+
+ @Override
+ public void setInterruptFlag(AtomicBoolean flag) {
+ this.interruptFlag = flag;
+ }
Review comment:
I agree. I am hesitant to go changing internals with the iterators
though since they are so heavily reliant on runtime configuration (one of the
reasons it took so long to find this bug in the first place) and I don't think
we have adequate test coverage for their behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
