milleruntime commented on pull request #2318: URL: https://github.com/apache/accumulo/pull/2318#issuecomment-963548309
> I can't reproduce that, so I'm assuming you're describing changes not included in this PR. Yes. I am using `CompactionCoordinatorService.Client` to call the method `getRunningCompactions`. It returns multiple thrift types, TExternalCompactionList and TExternalCompaction. > The monitor shouldn't interact with Thrift at all. It should interact with other service APIs, and those service APIs should not leak Thrift types, if at all possible. I don't understand what you mean. I am also not sure how the Monitor doesn't already have this dependency. The Monitor currently uses thrift types like `ManagerMonitorInfo` and `ManagerClientService` a great deal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
