ctubbsii edited a comment on pull request #2259: URL: https://github.com/apache/accumulo/pull/2259#issuecomment-964502910
@dlmarion I think I still have reservations about the "right" way to bootstrap OpenTelemetry from user preferences. However, I think marking the properties experimental should suffice for now (which I have done). The main outstanding concern now is lack of preserving of existing sampling granularity... that issue overlaps with the shell behavior change, in that dynamically turning tracing on and off in the shell is effectively toggling between an `ALWAYS` sampler and a `NEVER` sampler, dynamically at runtime. Given the difficulty of configuring that, I'm willing to punt on that for now. When we do revisit it, it might be worth taking a look at how to customize the autoconfigure implementation with a [sampler customizer](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure-spi/src/main/java/io/opentelemetry/sdk/autoconfigure/spi/AutoConfigurationCustomizer.java#L45) EDIT: Created followup issue #2352 to address sampling customization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
