keith-turner commented on a change in pull request #166:
URL: https://github.com/apache/accumulo-testing/pull/166#discussion_r751672084
##########
File path:
src/main/java/org/apache/accumulo/testing/continuous/ContinuousIngest.java
##########
@@ -177,10 +183,12 @@ public static void main(String[] args) throws Exception {
for (int depth = 1; depth < maxDepth; depth++) {
for (int index = 0; index < flushInterval; index++) {
long rowLong = genLong(rowMin, rowMax, r);
- byte[] prevRow = genRow(prevRows[index]);
- prevRows[index] = rowLong;
- Mutation m = genMutation(rowLong, r.nextInt(maxColF),
r.nextInt(maxColQ), cv,
- ingestInstanceId, count, prevRow, checksum);
+ byte[] prevRow = genRow(nodeMap[depth - 1][index].row);
+ int cfInt = r.nextInt(maxColF);
+ int cqInt = r.nextInt(maxColQ);
+ nodeMap[depth][index] = new MutationInfo(rowLong, cfInt, cqInt);
Review comment:
We may be able to avoid creating these MutationInfo objects when we are
not deleting. Would need to move the creation of the delete var to before this
loop. Less object creation may speed things up a bit when we are not deleting.
```suggestion
if(delete || depth == maxDepth - 1) {
nodeMap[depth][index] = new MutationInfo(rowLong, cfInt,
cqInt);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
