milleruntime commented on a change in pull request #2369:
URL: https://github.com/apache/accumulo/pull/2369#discussion_r758560528
##########
File path: test/src/main/java/org/apache/accumulo/test/ShellIT.java
##########
@@ -515,4 +516,77 @@ public void setIterTest() throws IOException {
exec("deletetable t -f", true, "Table: [t] has been deleted");
}
+
+ // This test addresses a bug (#2356) where if a table with a tableId of
character length 1
+ // exists and another table(s) exist starting with the same character but
with a tableId of
+ // length > 1, the verbose version of the getsplits command will return
information from multiple
+ // tables when a table with lexigraphically earlier ID is queried.
Review comment:
```suggestion
// tables when a lexicographical ordered table with an earlier ID is
queried.
```
##########
File path: test/src/main/java/org/apache/accumulo/test/ShellIT.java
##########
@@ -515,4 +516,77 @@ public void setIterTest() throws IOException {
exec("deletetable t -f", true, "Table: [t] has been deleted");
}
+
+ // This test addresses a bug (#2356) where if a table with a tableId of
character length 1
+ // exists and another table(s) exist starting with the same character but
with a tableId of
+ // length > 1, the verbose version of the getsplits command will return
information from multiple
+ // tables when a table with lexigraphically earlier ID is queried.
+ //
+ // In order to test, enough tables need to be created until the required
condition exists.
+ // Since table ID counts increment using 1..9a..z, this test creates tables
in groups of 36
+ // until a second table meeting the criteria is created.
+ // It then adds splits to the single digit ID table and one of the others.
It performs a
+ // "getsplits -v" command on the single digit ID table and verifies that
data from the other
+ // table is not present.
+ //
+ // Due to the number for createtable calls, this test will time out if a
match is not found
+ // within some number of operations. Therefore, if a match is not found
within the creation
+ // of the first 360 or so tables, the test exits witn no results. In initial
runs of the ITs
Review comment:
```suggestion
// of the first 360 or so tables, the test exits with no results. In
initial runs of the ITs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
