milleruntime commented on pull request #2368: URL: https://github.com/apache/accumulo/pull/2368#issuecomment-982007784
> unsure if this should be currFactor >= targetFactor .. need to think through some edge cases To test your comment, I added a test to GenerateSplitsTest that passes `--num 4` using the 6 splits. Based on the results, I don't think we want the "=". With a comparison of `currFactor > targetFactor` we get the splits: `r1, r2, r4, r5`. But with a comparison of `currFactor >= targetFactor` we get the splits: `r1, r2, r3, r5`. It seems like we get a better spread using `currFactor > targetFactor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
