milleruntime commented on pull request #2345: URL: https://github.com/apache/accumulo/pull/2345#issuecomment-983598273
> The most recent changes replace the error throwing with `System.err.println()` and `System.exit()` so that the errors can be seen from the shell. I removed most of the tests since im not too sure how we can verify which errors are being thrown while using `System.exit()` but from my manual testing, everything seems to be working. You should be able to see Exceptions thrown by the utility. Maybe something is wrong with your Log4j.properties file? How are you running the command? The only time I think we want to use `System.out.println()` is for a standalone command line tool that can pipe the output to other CLI tools and you don't want logging information mucking up the output. We only want to use `System.exit()` in very rare circumstances. There was work done in Accumulo over the years to avoid calls to `System.exit()`. And I can't think of a reason to call `System.err.println()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
