ctubbsii commented on issue #2362:
URL: https://github.com/apache/accumulo/issues/2362#issuecomment-983956538


   > 
[wip](https://github.com/dlmarion/accumulo/commit/c2073c5046ddc5b9bd5061f9f9265aefac4d98aa)
 - in case you were wondering where I was headed
   
   That's the basic direction I was headed also. I called mine 
`TraceWrapped{Callable,Runnable}`, but had the same `unwrap` method. The main 
thing I did differently was I saved a reference to the original context, to 
call make it current in the `run` method, rather than use the `Context.wrap` 
method at all. That way, it's only wrapped once, instead of twice. I was going 
through the rest of the use cases to see if there's any further cleanup I can 
do to make sure there aren't similar issues. Another issue that is possible to 
encounter is trying to remove a wrapped runnable from the blocking queue, and 
not actually removing it because the wrapper doesn't equal the wrapped Runnable 
or isn't the right type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to