milleruntime commented on a change in pull request #2368:
URL: https://github.com/apache/accumulo/pull/2368#discussion_r765991529
##########
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/GenerateSplits.java
##########
@@ -201,7 +201,9 @@ public void execute(String[] args) throws Exception {
itemsSketch.update(row);
iterator.next();
}
- return itemsSketch.getQuantiles(numSplits);
+ Text[] items = itemsSketch.getQuantiles(numSplits + 2);
Review comment:
> The class seems to buffer information in memory, but I don't have a
good sense of what if any limits there are on how much it will buffer.
That is a good question, I am not sure either. Perhaps this utility is a
good, harmless way to test the limits of the library, in the case where we want
to use it in other, more important parts of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
