DomGarguilo commented on a change in pull request #2345: URL: https://github.com/apache/accumulo/pull/2345#discussion_r775626408
########## File path: server/base/src/main/java/org/apache/accumulo/server/conf/CheckCompactionConfig.java ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.server.conf; + +import java.io.FileNotFoundException; +import java.nio.file.Path; +import java.util.Set; + +import org.apache.accumulo.core.cli.Help; +import org.apache.accumulo.core.conf.AccumuloConfiguration; +import org.apache.accumulo.core.conf.SiteConfiguration; +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.core.spi.common.ServiceEnvironment; +import org.apache.accumulo.core.spi.compaction.CompactionPlanner; +import org.apache.accumulo.core.spi.compaction.CompactionServiceId; +import org.apache.accumulo.core.util.ConfigurationImpl; +import org.apache.accumulo.core.util.compaction.CompactionPlannerInitParams; +import org.apache.accumulo.core.util.compaction.CompactionServicesConfig; +import org.apache.accumulo.start.spi.KeywordExecutable; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.beust.jcommander.Parameter; +import com.google.auto.service.AutoService; + +@AutoService(KeywordExecutable.class) +public class CheckCompactionConfig implements KeywordExecutable { + + private final static Logger log = LoggerFactory.getLogger(CheckCompactionConfig.class); + + static class Opts extends Help { + @Parameter(description = "<path/to/props/file>", required = true) + String filePath; + } + + @Override + public String keyword() { + return "check-compaction-config"; + } + + @Override + public String description() { + return "Verifies compaction config within a given file"; + } + + public static void main(String[] args) throws Exception { + new CheckCompactionConfig().execute(args); + } + + @Override + public void execute(String[] args) throws Exception { + Opts opts = new Opts(); + opts.parseArgs("accumulo check-compaction-config", args); + + if (opts.filePath == null) { + throw new IllegalArgumentException("No properties file was given"); + } + + Path path = Path.of(opts.filePath); + if (!path.toFile().exists()) + throw new FileNotFoundException("File at given path could not be found"); + + AccumuloConfiguration config = SiteConfiguration.fromFile(path.toFile()).build(); + var servicesConfig = new CompactionServicesConfig(config, log::warn); + ServiceEnvironment senv = createServiceEnvironment(config); + + Set<String> defaultServices = Set.of("default", "meta", "root"); + if (servicesConfig.getPlanners().keySet().equals(defaultServices)) { + throw new IllegalArgumentException("Only the default compaction services were created"); Review comment: Addressed in 76b4e70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
