DomGarguilo opened a new pull request #2421: URL: https://github.com/apache/accumulo/pull/2421
Closes #2413 #2413 was created to address the possibility of two things: * Reusing common code within ScanDataSource * Closing resources that were left open (readers, files) It seems that neither of these should be done. The original Jira ticket referenced shared code between OfflineIterator and Tablet, but since then, the code has moved to ScanDataSource and changed significantly meaning extracting commonalities between the two may not be worth it/feasible. The second point about closing the resources proves to cause error. If the readers or files are closed, the iterator fails to read the intended data therefore I think its best if they are not closed. The changes made in this PR: * Remove the comments that refer to these issues * Make some variables final * Simplify some logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
