ctubbsii commented on a change in pull request #2414:
URL: https://github.com/apache/accumulo/pull/2414#discussion_r789346524
##########
File path:
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java
##########
@@ -327,6 +334,13 @@ public MiniAccumuloClusterImpl(MiniAccumuloConfigImpl
config) throws IOException
this.config = config.initialize();
+ if (Boolean.TRUE.equals(Boolean
+
.valueOf(this.config.getSiteConfig().get(Property.TSERV_NATIVEMAP_ENABLED.name()))))
{
+ if (!NativeMap.isLoaded())
+ throw new RuntimeException(
+ "MAC configured to use native maps, but unable to load the
library.");
+ }
+
Review comment:
After fixing the bug where the config was being checked to see if the
native maps were enabled (using `Property.name()` instead of
`Property.getKey()`), I was able to confirm that this does, in fact, fail
because the native maps can't be loaded in the test thread. `mvn clean verify
-Dtest=blah -Dit.test=WALSunnyDayIT` is an easy one to use to reproduce this,
since it extends `ConfigurableMacBase`, and doesn't disable the native maps.
So, this native map loading check in the test thread really needs to be
removed for this to have any chance of verifyUp working properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
