brianloss commented on pull request #185: URL: https://github.com/apache/accumulo-testing/pull/185#issuecomment-1028333852
> @brianloss - I agree with your assessment, it could be restructured to make parts of it more reusable. I just don't have access to another cloud provider to test with and figure out what needs to move. Gotcha. I can think of a couple approaches: 1. Take a stab at it. It won't necessarily be perfect/guaranteed to work w/o changes on other providers. If the terraform thing you're calling (data, resource, module) starts with the name aws, then it's aws-specific. Starting with that will probably get 95% of the way there. 2. I can try it out (though like you, I only have access to resources on one cloud provider--Azure in my case) and submit a PR against your PR. I'll be able to test with Azure to make sure that works, and you could test with AWS on a locally merged copy. 3. Submit as-is, and when I or someone else wants to support another cloud, do all of the moves then. 2 is probably the best, but might hold you up a little bit. Any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
