milleruntime commented on a change in pull request #2457:
URL: https://github.com/apache/accumulo/pull/2457#discussion_r798920107
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/AuthenticationTokenIdentifier.java
##########
@@ -41,104 +40,61 @@
public class AuthenticationTokenIdentifier extends TokenIdentifier {
public static final Text TOKEN_KIND = new Text("ACCUMULO_AUTH_TOKEN");
- private TAuthenticationTokenIdentifier impl = null;
- private DelegationTokenConfig cfg = null;
+ private final TAuthenticationTokenIdentifier impl;
public AuthenticationTokenIdentifier() {
- // noop for Writable
- }
-
- public AuthenticationTokenIdentifier(String principal) {
- this(principal, null);
- }
-
- public AuthenticationTokenIdentifier(String principal, DelegationTokenConfig
cfg) {
- requireNonNull(principal);
- impl = new TAuthenticationTokenIdentifier(principal);
- this.cfg = cfg;
- }
-
- public AuthenticationTokenIdentifier(String principal, int keyId, long
issueDate,
- long expirationDate, String instanceId) {
- requireNonNull(principal);
- impl = new TAuthenticationTokenIdentifier(principal);
- impl.setKeyId(keyId);
- impl.setIssueDate(issueDate);
- impl.setExpirationDate(expirationDate);
- impl.setInstanceId(instanceId);
- }
-
- public AuthenticationTokenIdentifier(AuthenticationTokenIdentifier
identifier) {
- requireNonNull(identifier);
- impl = new
TAuthenticationTokenIdentifier(identifier.getThriftIdentifier());
+ impl = new TAuthenticationTokenIdentifier();
+ populateFields(impl);
}
public AuthenticationTokenIdentifier(TAuthenticationTokenIdentifier
identifier) {
requireNonNull(identifier);
impl = new TAuthenticationTokenIdentifier(identifier);
+ populateFields(identifier);
}
public void setKeyId(int keyId) {
impl.setKeyId(keyId);
}
public int getKeyId() {
- requireNonNull(impl, "Identifier not initialized");
return impl.getKeyId();
}
public void setIssueDate(long issueDate) {
- requireNonNull(impl, "Identifier not initialized");
impl.setIssueDate(issueDate);
}
public long getIssueDate() {
- requireNonNull(impl, "Identifier not initialized");
return impl.getIssueDate();
}
public void setExpirationDate(long expirationDate) {
- requireNonNull(impl, "Identifier not initialized");
impl.setExpirationDate(expirationDate);
}
public long getExpirationDate() {
- requireNonNull(impl, "Identifier not initialized");
return impl.getExpirationDate();
}
public void setInstanceId(String instanceId) {
- requireNonNull(impl, "Identifier not initialized");
impl.setInstanceId(instanceId);
}
public String getInstanceId() {
- requireNonNull(impl, "Identifier not initialized");
return impl.getInstanceId();
}
public TAuthenticationTokenIdentifier getThriftIdentifier() {
- requireNonNull(impl);
return impl;
}
- /**
- * A configuration from the requesting user, may be null.
- */
- public DelegationTokenConfig getConfig() {
- return cfg;
- }
-
@Override
public void write(DataOutput out) throws IOException {
- if (impl != null) {
- ThriftMessageUtil msgUtil = new ThriftMessageUtil();
- ByteBuffer serialized = msgUtil.serialize(impl);
- out.writeInt(serialized.limit());
- ByteBufferUtil.write(out, serialized);
- } else {
- out.writeInt(0);
- }
+ ThriftMessageUtil msgUtil = new ThriftMessageUtil();
+ ByteBuffer serialized = msgUtil.serialize(impl);
+ out.writeInt(serialized.limit());
+ ByteBufferUtil.write(out, serialized);
}
Review comment:
This will change the serialization but I am not sure if it matters or
not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
