dlmarion commented on a change in pull request #2467:
URL: https://github.com/apache/accumulo/pull/2467#discussion_r800837861
##########
File path:
test/src/main/java/org/apache/accumulo/test/fate/zookeeper/FateIT.java
##########
@@ -71,35 +76,63 @@ public TestOperation(NamespaceId namespaceId, TableId
tableId) {
@Override
public long isReady(long tid, Manager manager) throws Exception {
- return Utils.reserveNamespace(manager, namespaceId, tid, false, true,
TableOperation.RENAME)
- + Utils.reserveTable(manager, tableId, tid, true, true,
TableOperation.RENAME);
+ LOG.info("Entering isReady {}", Long.toHexString(tid));
+ try {
+ FateIT.inReady();
+ return Utils.reserveNamespace(manager, namespaceId, tid, false, true,
TableOperation.RENAME)
+ + Utils.reserveTable(manager, tableId, tid, true, true,
TableOperation.RENAME);
+ } finally {
+ LOG.info("Leaving isReady {}", Long.toHexString(tid));
+ }
}
@Override
public void undo(long tid, Manager manager) throws Exception {
- Utils.unreserveNamespace(manager, namespaceId, tid, false);
- Utils.unreserveTable(manager, tableId, tid, true);
+ LOG.info("Entering undo {}", Long.toHexString(tid));
+ try {
+ Utils.unreserveNamespace(manager, namespaceId, tid, false);
+ Utils.unreserveTable(manager, tableId, tid, true);
+ } finally {
+ LOG.info("Leaving undo {}", Long.toHexString(tid));
+ }
}
@Override
- public Repo<Manager> call(long tid, Manager environment) throws Exception {
- FateIT.inCall();
- return null;
+ public Repo<Manager> call(long tid, Manager manager) throws Exception {
+ LOG.info("Entering call {}", Long.toHexString(tid));
+ try {
+ FateIT.inCall();
+ return null;
+ } finally {
+ Utils.unreserveNamespace(manager, namespaceId, tid, false);
+ Utils.unreserveTable(manager, tableId, tid, true);
+ LOG.info("Leaving call {}", Long.toHexString(tid));
Review comment:
Addressed in c9e64f4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]