DomGarguilo edited a comment on pull request #2472: URL: https://github.com/apache/accumulo/pull/2472#issuecomment-1036401176
> The ErrorProne plugin also pointed out a test that looks like it is not behaving as intended. > > https://github.com/apache/accumulo/blob/3ea979d5971016b9c2512a96cc5b6bd5d1969b2e/server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java#L348-L359 > > It looks like the test is expecting the the call to `recover()` to fail and if it doesn't, the test will fail via the call to `fail()`. But in this case, the `fail()` statement will be caught as a `Throwable` and **not** cause the test to fail when reached, Functionally, the whole try catch block does nothing more than call `recover()`. I'm not certain im interpreting this correctly but if I am, I'm not sure how to handle this case. Im still not too sure what to do in this case. I don't think I made it clear originally that the call to recover() does not throw an exception so the test hits the fail() every time (which is caught and ignored). This does not seem like it is the intended behavior of the test - it seems like the test expects the call to recover to throw an exception which does not happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
