dlmarion commented on a change in pull request #2530:
URL: https://github.com/apache/accumulo/pull/2530#discussion_r816095404
##########
File path:
core/src/main/java/org/apache/accumulo/core/util/threads/AccumuloUncaughtExceptionHandler.java
##########
@@ -32,11 +32,40 @@
private static final Logger LOG =
LoggerFactory.getLogger(AccumuloUncaughtExceptionHandler.class);
+ static boolean isError(Throwable t, int depth) {
+
+ if (depth > 32) {
+ // This is a peculiar exception. No error has been found, but recursing
too deep may cause a
+ // stack overflow so going to stop.
+ return false;
Review comment:
I think returning false is fine here. If we really wanted to be
complete, then we would likely have to change this method to check the
suppressed exceptions in an iterative manner instead of recursive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
