ctubbsii commented on a change in pull request #2539:
URL: https://github.com/apache/accumulo/pull/2539#discussion_r817999928



##########
File path: core/src/main/java/org/apache/accumulo/fate/Fate.java
##########
@@ -81,6 +81,11 @@ public void run() {
             try {
               deferTime = op.isReady(tid, environment);
 
+              // For this if/else statenebt, the deferTime value is treated as 
an exit code, where
+              // 0 indicates success and processing continues. A non-zero 
value indicates that
+              // processing should not immediately proceed and another loop of 
the while occurs.
+              // The actual deferTime value is utilized as a wait time within 
the ZooStore
+              // class.

Review comment:
       This is a bit verbose. Perhaps:
   
   ```suggestion
                 // Here, deferTime is only used to determine success (zero) or 
failure (non-zero),
                 // proceeding on success and returning to the while loop on 
failure.
                 // The value of deferTime is only used as a wait time in 
ZooStore.unreserve
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to