ctubbsii commented on a change in pull request #2547:
URL: https://github.com/apache/accumulo/pull/2547#discussion_r821650524
##########
File path:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/LruBlockCache.java
##########
@@ -520,7 +521,7 @@ public long getEvictedCount() {
public EvictionThread(LruBlockCache cache) {
super("LruBlockCache.EvictionThread");
- setDaemon(true);
+ Threads.applyStandardsToThread(this, "LruBlockCache.EvictionThread");
Review comment:
Maybe this should be turned into a Runnable instead so we use it with
our regular utilities? It might not be necessary to create thread objects
directly.
Or, if extending Thread is necessary, would it be cleaner to have a base
Thread class to extend?
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java
##########
@@ -113,8 +114,7 @@
this.manager = manager;
this.store = store;
this.dependentWatcher = dependentWatcher;
- setName("Watching " + store.name());
- setDaemon(true);
+ Threads.applyStandardsToThread(this, "Watching " + store.name());
Review comment:
Might be able to make this one a Runnable also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
