dlmarion commented on a change in pull request #2558:
URL: https://github.com/apache/accumulo/pull/2558#discussion_r823066645



##########
File path: 
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportKey.java
##########
@@ -91,7 +91,7 @@ public boolean equals(Object o) {
   }
 
   public final void precomputeHashCode() {
-    hashCode();
+    var unusedRetVal = hashCode();

Review comment:
       seems like in this case you could compute the `hash` in the ctor and get 
rid of this method




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to