ctubbsii commented on a change in pull request #2562:
URL: https://github.com/apache/accumulo/pull/2562#discussion_r823950708
##########
File path:
shell/src/main/java/org/apache/accumulo/shell/commands/FateCommand.java
##########
@@ -108,9 +109,8 @@ public JsonElement serialize(byte[] link, Type type,
JsonSerializationContext co
}
}
- private Option secretOption;
- private Option statusOption;
- private Option disablePaginationOpt;
+ private Option cancel, delete, dump, fail, list, print, secretOption,
statusOption,
+ disablePaginationOpt;
Review comment:
nit. This makes diffs much easier to understand when code changes. I
would strongly prefer one line per variable.
##########
File path:
shell/src/main/java/org/apache/accumulo/shell/commands/FateCommand.java
##########
@@ -243,7 +248,7 @@ private boolean cancelSubmittedTxs(final Shell shellState,
String[] args)
throws AccumuloException, AccumuloSecurityException {
ClientContext context = shellState.getContext();
for (int i = 1; i < args.length; i++) {
- Long txid = Long.parseLong(args[i]);
+ Long txid = Long.parseLong(args[i], 16);
Review comment:
Not sure why this is being auto-boxed here.
`ManagerClient.cancelFateOperation(context, txid)` should also take a `long`
not a `Long`, because by the time it gets to
`FateService.Client.cancelFateOperation(...)` it is a `long`, not a `Long`.
Using `Long` just unnecessarily auto-boxes and auto-unboxes.
```suggestion
long txid = Long.parseLong(args[i], 16);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
