EdColeman commented on a change in pull request #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r830306227
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/ServerContext.java
##########
@@ -158,10 +165,8 @@ public synchronized ServerConfigurationFactory
getServerConfFactory() {
@Override
public AccumuloConfiguration getConfiguration() {
if (systemConfig == null) {
- // system configuration uses its own instance of ZooCache
- // this could be useful to keep its update counter independent
- ZooCache propCache = new ZooCache(getZooReader(), null);
- systemConfig = new ZooConfiguration(this, propCache,
getSiteConfiguration());
+ systemConfig = new SystemConfiguration(log, this,
PropCacheId.forSystem(getInstanceID()),
Review comment:
I do not understand this comment with the current code. Should the
logger be the logger that is created in ServerContext - or not passed in and a
logger created in SystemConfiguration, or something else?
Neither really seem to add the clarity if they were passed in from the
process / service that was creating the context / configuration - but that also
ends up being the process log. Basically passing in the log didn't help when I
was debugging things that would not have been available from a logger
instantiated in the configuration itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
