dlmarion commented on a change in pull request #2422:
URL: https://github.com/apache/accumulo/pull/2422#discussion_r837502657
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/ThriftClientHandler.java
##########
@@ -353,36 +367,38 @@ public InitialScan startScan(TInfo tinfo, TCredentials
credentials, TKeyExtent t
}
@Override
- public ScanResult continueScan(TInfo tinfo, long scanID) throws
NoSuchScanIDException,
- NotServingTabletException,
org.apache.accumulo.core.tabletserver.thrift.TooManyFilesException,
- TSampleNotPresentException {
+ public ScanResult continueScan(TInfo tinfo, long scanID, long busyTimeout)
+ throws NoSuchScanIDException, NotServingTabletException,
+ org.apache.accumulo.core.tabletserver.thrift.TooManyFilesException,
+ TSampleNotPresentException, ScanServerBusyException {
SingleScanSession scanSession =
(SingleScanSession) server.sessionManager.reserveSession(scanID);
if (scanSession == null) {
throw new NoSuchScanIDException();
}
try {
- return continueScan(tinfo, scanID, scanSession);
+ return continueScan(tinfo, scanID, scanSession, busyTimeout);
} finally {
server.sessionManager.unreserveSession(scanSession);
}
}
- private ScanResult continueScan(TInfo tinfo, long scanID, SingleScanSession
scanSession)
- throws NoSuchScanIDException, NotServingTabletException,
+ protected ScanResult continueScan(TInfo tinfo, long scanID,
SingleScanSession scanSession,
+ long busyTimeout) throws NoSuchScanIDException,
NotServingTabletException,
org.apache.accumulo.core.tabletserver.thrift.TooManyFilesException,
- TSampleNotPresentException {
+ TSampleNotPresentException, ScanServerBusyException {
if (scanSession.nextBatchTask == null) {
+ // TODO look into prioritizing continue scan task in thread pool queue
Review comment:
Is this another case where we can satisfy this TODO by creating a
separate ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
