EdColeman commented on code in PR #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r850766104
##########
server/base/src/main/java/org/apache/accumulo/server/conf/codec/VersionedPropCodec.java:
##########
@@ -152,28 +171,26 @@ public static int getEncodingVersion(final byte[] bytes) {
}
/**
- * Extracts the data version from the encoded byte array without fully
decoding the payload.
- * Normally the data version should be obtained from a fully decoded
instance of the versioned
- * properties.
+ * Extracts the timestamp from the encoded byte array without fully decoding
the payload. Normally
+ * the timestamp should be obtained from a fully decoded instance of the
versioned properties.
* <p>
* The cost of reading the byte array from the backing store should be
considered verses the
* additional cost of decoding - with a goal of reducing data reads from the
store preferred.
* Generally reading from the store will be followed by some sort of usage
which would require the
- * full decode operation anyway.
+ * full decode operation anyway, so uses of this method should be narrow and
limited.
*
* @param bytes
* serialized encoded versioned property byte array.
- * @return the encoding version used to serialize the properties.
+ * @return the timestamp used to serialize the properties.
*/
- public static int getDataVersion(final byte[] bytes) {
+ public static Instant readTimestamp(final byte[] bytes) {
try (ByteArrayInputStream bis = new ByteArrayInputStream(bytes);
DataInputStream dis = new DataInputStream(bis)) {
// skip encoding metadata
Review Comment:
fixed in d4919ee945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
