ctubbsii commented on code in PR #2636:
URL: https://github.com/apache/accumulo/pull/2636#discussion_r851542494
##########
server/manager/src/test/java/org/apache/accumulo/manager/tableOps/bulkVer2/PrepBulkImportTest.java:
##########
@@ -79,14 +79,11 @@ List<KeyExtent> createExtents(Iterable<String> rowsIter) {
Iterable<List<KeyExtent>> powerSet(KeyExtent... extents) {
Set<Set<KeyExtent>> powerSet = Sets.powerSet(Set.of(extents));
-
- return Iterables.transform(powerSet, set -> {
+ return () -> powerSet.stream().map(set -> {
List<KeyExtent> list = new ArrayList<>(set);
-
Collections.sort(list);
-
return list;
- });
+ }).iterator();
Review Comment:
I would love to use Iterable less often, and Streams more. We definitely
should do that. But that's a much larger change, as those kinds of things
cascade. This was a minimal change to modernize this and avoid the Guava
Iterables class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
