dlmarion commented on PR #2620: URL: https://github.com/apache/accumulo/pull/2620#issuecomment-1102823450
> It does add a small amount of data to each RPC request, looking at the javadoc for `TMultiplexedProcessor` it seems the servicename from the thrift IDL is added to each RPC request. So scan RPCs may now have the extra data `TabletClientService` from the service name defined in the idl. Not sure if this will matter or if it would be worthwhile to have a shorter service name. I know the javadoc says that the service name from the Thrift IDL is to be used, but I don't see anything in the code that enforces it. I think it might be possible to leave the IDL as-is and just register the TProcessors with a different service name in the `TMultiplexedProcessor.register(String serviceName, TProcessor processor)` [call](https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/TMultiplexedProcessor.java#L67). If that works, then we could have an enum or something that is used by the client and server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
