EdColeman commented on code in PR #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r858634688
##########
test/src/main/java/org/apache/accumulo/test/start/KeywordStartIT.java:
##########
@@ -113,6 +115,8 @@ public void testExpectedClasses() {
expectSet.put("check-server-config", CheckServerConfig.class);
expectSet.put("compaction-coordinator", CoordinatorExecutable.class);
expectSet.put("compactor", CompactorExecutable.class);
+ expectSet.put("config-print", ConfigPropertyPrinter.class);
+ expectSet.put("config-upgrade", ConfigPropertyUpgrader.class);
Review Comment:
It is a one-off, and as soon as we can assert that 2.1 is the base version
for any future upgrades, all of the upgrade code related to the property
conversion should be removed - that includes this utility. If other general,
pre-start utilities are needed, they can be created at that time.
I have no issue with renaming if that makes it clearer when / if it should
be run and if it establishes a convention if future tasks are needed - just
seeking clarification on your intent with this suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
