kitswas commented on code in PR #2712:
URL: https://github.com/apache/accumulo/pull/2712#discussion_r874800915
##########
core/src/main/java/org/apache/accumulo/core/util/threads/ThreadPools.java:
##########
@@ -515,7 +519,7 @@ public Future<?> submit(Runnable task) {
public ScheduledThreadPoolExecutor
createGeneralScheduledExecutorService(AccumuloConfiguration conf) {
return (ScheduledThreadPoolExecutor) createExecutorService(conf,
- Property.GENERAL_SIMPLETIMER_THREADPOOL_SIZE, true);
+ Property.GENERAL_THREADPOOL_SIZE, true);
Review Comment:
> I'm not sure this is sufficient. The old property is deprecated, not
removed. This means that users may have the old property, and not the new one,
in their configuration. I think you need to check for both and maybe use the
one that has a larger value.
Since `createGeneralScheduledExecutorService()` creates a new service, I
felt it should use the new property `GENERAL_THREADPOOL_SIZE` to do so.
You suggestion, to use the one that has a larger value, is valid.
Alternatively, for backward compatibility, we can have an overloaded version
of the function that uses the new property and leave the old function as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
