kitswas commented on PR #2712: URL: https://github.com/apache/accumulo/pull/2712#issuecomment-1132835553
> Any proposed changes here should include any necessary adjustments to tests that would otherwise be left broken if the changes were accepted. Guidance requested. > Okay, it looks like those indicate the problem is likely with using an AccumuloConfiguration object for testing that doesn't override the method. That should never happen in runtime. It seems the tests need to be fixed. "That should never happen in runtime. " - Then why was it in the tests? Should the tests be rewritten or, considering the tests were for an _impossible_ condition, be deleted outright? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
