ctubbsii commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r880853288
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java:
##########
@@ -419,6 +438,7 @@ public Options getOptions() {
outputFileOpt.setArgName("file");
contextOpt.setArgName("context");
executionHintsOpt.setArgName("<key>=<value>{,<key>=<value>}");
+ scanServerOpt.setArgName("immediate|eventual");
Review Comment:
The names should imply "use an eventually consistent scan server" instead of
"create an eventually consistent scanner". In other words, the name should
explicitly declare the resource that the scanner is allowed to use, rather than
a characteristic trait of the scanner itself. The scanner characteristics are
not inherent to the scanner, but the result of using the particular server type.
For the shell, `--use-scan-server` (with description that says scan servers
offer eventual consistency) would be better than `--consistency eventual` on
the scanner.
For the Scanner API, perhaps `permitScanServer()`, which allows the scanner
to use scan server's, if they are available, with a javadoc that explains that
scan servers are eventually consistent.
This changes the way we think about the Scanner object, based on the
resources it is using (and characteristics that result from using those
resources; eventual consistency is only one such characteristic... other
characteristics are also applicable... like potential for less resource
contention on the server-side, potentially dynamically scalable, etc.), rather
than altering the inherent characteristics of the Scanner object itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
