ctubbsii commented on PR #2712:
URL: https://github.com/apache/accumulo/pull/2712#issuecomment-1136704746

   > In retrospect, commit 
[6189662](https://github.com/apache/accumulo/commit/6189662b0766debf42d199e148e8f52a9c6fe13c)
 and the tests came close to the scenario described in the [Broken windows 
theory](https://blog.codinghorror.com/the-broken-window-theory/). If commit 
[6189662](https://github.com/apache/accumulo/commit/6189662b0766debf42d199e148e8f52a9c6fe13c)
 were kept, it would have been an excuse to skip fixing the tests in future.
   
   Thanks for the good read. I was roughly familiar with the concept, but I 
hadn't thought about it in terms of programming. Seems obvious now. :smiley_cat:
   
   > 
   > > If you intend to be a regular contributor to Accumulo projects, please 
consider subscribing to our developer mailing list 
(https://accumulo.apache.org/contact-us/) and introducing yourself. smiley_cat
   > 
   > Very tempting, almost dangerously so, but I think I will pass. My passion 
(programming, computers) is different from my profession. It has always been 
so. Hopefully, they will merge after I graduate.
   
   Many Apache projects have contributors who contribute as a hobby. You're not 
alone there :smiley_cat:
   
   > 
   > I primarily use Windows. [Apache Accumulo does not like 
that](https://stackoverflow.com/a/15540833/8659747). While I can [build using 
WSL](https://stackoverflow.com/a/72335829/8659747), WSL does not mesh well with 
most GUI tools (IntelliJ, Gitkraken, ...) other than VS Code.
   
   While it is highly unlikely that Accumulo will ever support Windows as a 
production platform, it's pretty common to do development on Windows. If there 
are small things here and there that we can do to make that easier, I think 
we'd be open to pull requests. But if there isn't an active interest to 
maintain that support, it will likely break over time. It's possible that 
future improvements to WSL will make Windows more seamless with Windows. You 
could also try running a virtual machine. Although, my personal recommendation 
is to just get used to using Linux :smiley_cat:
   
   > 
   > > Thanks for the PR @kitswas. If you wish to be added as a contributor to 
https://accumulo.apache.org/people/, please open a pull request to add yourself 
at https://github.com/apache/accumulo-website/edit/main/pages/people.md and 
leave a reference to #2712 in your commit log.
   > 
   > Is it alright to do this when you did most of the work?
   
   I would disagree with that assessment. I did the work on the tests, but 
those were merged separately. You did the work for this PR, and you helped 
identify the bugs in the tests that inspired those changes. My alterations to 
this PR ended up being very minimal code. But that's normal collaboration / 
code review. You were a part of that and can still take credit for your part in 
the collaboration!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to