milleruntime commented on code in PR #2750:
URL: https://github.com/apache/accumulo/pull/2750#discussion_r888193312
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -635,31 +637,34 @@ private void deleteTablets(MergeInfo info) throws
AccumuloException {
ServerColumnFamily.TIME_COLUMN.fetch(scanner);
scanner.fetchColumnFamily(DataFileColumnFamily.NAME);
scanner.fetchColumnFamily(CurrentLocationColumnFamily.NAME);
- Set<String> datafiles = new TreeSet<>();
+ Set<Reference> datafilesAndDirs = new TreeSet<>();
Review Comment:
> I thought that all file references in the metadata table were absolute
If it is to a file, then yes, it should be... eventually. The GC uses
references to directories, and passes them around as Strings. See
https://github.com/apache/accumulo/blob/76aaba0ec4e086ab535a1e88ba6ecb0f62481b2c/server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java#L71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
