EdColeman commented on code in PR #2769:
URL: https://github.com/apache/accumulo/pull/2769#discussion_r895024272
##########
server/base/src/main/java/org/apache/accumulo/server/conf/ServerConfigurationFactory.java:
##########
@@ -48,11 +71,32 @@ public class ServerConfigurationFactory extends
ServerConfiguration {
private final SiteConfiguration siteConfig;
private final Supplier<SystemConfiguration> systemConfig;
+ private final ScheduledFuture<?> refreshTaskFuture;
+
+ private final DeleteWatcher deleteWatcher =
+ new DeleteWatcher(tableConfigs, namespaceConfigs, tableParentConfigs);
+
public ServerConfigurationFactory(ServerContext context, SiteConfiguration
siteConfig) {
this.context = context;
this.siteConfig = siteConfig;
systemConfig = Suppliers.memoize(
() -> new SystemConfiguration(context, SystemPropKey.of(context),
getSiteConfiguration()));
+
+ if (context.threadPools() != null) {
+ // simplify testing - only create refresh thread when operating in a
context with thread pool
Review Comment:
When mocking it is null - otherwise the pool needs to added to the mock and
it seemed to cause a circular dependency in the mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
