dlmarion commented on code in PR #2797:
URL: https://github.com/apache/accumulo/pull/2797#discussion_r914003845
##########
server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/ZooPropStore.java:
##########
@@ -172,8 +172,8 @@ public void create(PropStoreKey<?> propStoreKey,
Map<String,String> props) {
*/
@Override
public @NonNull VersionedProperties get(final PropStoreKey<?> propStoreKey) {
- checkZkConnection(); // if ZK not connected, block, do not just return a
cached value.
propStoreWatcher.registerListener(propStoreKey, this);
+ checkZkConnection(); // if ZK not connected, block, do not just return a
cached value.
Review Comment:
I needed to move this line down for my test to work because I was closing
the zookeeper server connection in `checkZKConnection` and I needed the watcher
to notice the connection closed event. I'm not sure if this is helpful,
hurtful, or benign in a non-test scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
