dlmarion commented on code in PR #2804:
URL: https://github.com/apache/accumulo/pull/2804#discussion_r926890612
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java:
##########
@@ -1105,23 +1105,23 @@ public Optional<Files> getFiles(CompactionServiceId
service, CompactionKind kind
}
class CompactionCheck {
- private final Supplier<Boolean> memoizedCheck;
+ private final Supplier<Boolean> expensiveCheck;
+ private final Supplier<Boolean> inexpensiveCheck;
public CompactionCheck(CompactionServiceId service, CompactionKind kind,
Long compactionId) {
- this.memoizedCheck = Suppliers.memoizeWithExpiration(() -> {
- if (closed)
+ this.expensiveCheck = Suppliers.memoizeWithExpiration(() -> {
+ return service.equals(getConfiguredService(kind));
+ }, 3, TimeUnit.SECONDS);
+ this.inexpensiveCheck = Suppliers.memoizeWithExpiration(() -> {
+ if (closed
+ || (kind == CompactionKind.USER &&
lastSeenCompactionCancelId.get() >= compactionId))
return false;
- if (!service.equals(getConfiguredService(kind)))
- return false;
- if (kind == CompactionKind.USER && lastSeenCompactionCancelId.get() >=
compactionId)
- return false;
-
return true;
- }, 100, TimeUnit.MILLISECONDS);
+ }, 50, TimeUnit.MILLISECONDS);
Review Comment:
No reason. I figured that since the less and more complex checks were
separated, that they could run at different intervals. I figured it made sense
to lower the less complex check interval so that compactions could be cancelled
a little faster if needed. This too was arbitrary, I could have left it at 100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
