cshannon commented on PR #2799: URL: https://github.com/apache/accumulo/pull/2799#issuecomment-1207221845
> > I went ahead and squashed my commits into 1 (leaving Emily's) and I also rebased and removed the draft status as I think this PR is about ready to merge after a final review. > > > > Squashing isn't necessary usually. We squash when we merge the final PR. Squashing and force pushing can make it harder to follow the history of the ticket while reviewing. Ok sounds good in the future I can leave the commits and squash later on merge. I still like force pushing when just rebasing though as nothing is changing with the commit itself (usually) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
