EdColeman opened a new pull request, #2861:
URL: https://github.com/apache/accumulo/pull/2861
Fix spotbugs errors identified by temporarily setting the spotbugs effort
maxRank at 17 (normally 16). In core, there are 35 errors identified - this PR
address 17 of them.
<details>
<summary>Fixed errors - Click to expand!</summary>
- [ERROR] Medium: Hard coded reference to an absolute pathname in
org.apache.accumulo.core.client.ClientPropertiesTest.testBasic()
[org.apache.accumulo.core.client.ClientPropertiesTest] At
ClientPropertiesTest.java:[line 45] DMI_HARDCODED_ABSOLUTE_FILENAME
- [ERROR] Medium: Return value of
java.util.regex.Pattern.matcher(CharSequence) ignored, but method has no side
effect [org.apache.accumulo.core.iterators.user.RegExFilter,
org.apache.accumulo.core.iterators.user.RegExFilter,
org.apache.accumulo.core.iterators.user.RegExFilter,
org.apache.accumulo.core.iterators.user.RegExFilter] At RegExFilter.java:[line
178]Another occurrence at RegExFilter.java:[line 181]Another occurrence at
RegExFilter.java:[line 184]Another occurrence at RegExFilter.java:[line 187]
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
- [ERROR] Medium: Dead store to more in
org.apache.accumulo.core.metadata.MetadataLocationObtainer.lookupTablet(ClientContext,
TabletLocator$TabletLocation, Text, Text, TabletLocator)
[org.apache.accumulo.core.metadata.MetadataLocationObtainer] At
MetadataLocationObtainer.java:[line 118] DLS_DEAD_LOCAL_STORE
- [ERROR] Medium: Write to static field
org.apache.accumulo.core.spi.balancer.TableLoadBalancerTest.state from instance
method org.apache.accumulo.core.spi.balancer.TableLoadBalancerTest.test()
[org.apache.accumulo.core.spi.balancer.TableLoadBalancerTest] At
TableLoadBalancerTest.java:[line 136] ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
- [ERROR] Medium: Integral division result cast to double or float in
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest.testEvenWeightsNoCaching()
[org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest,
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest] At
SpaceAwareVolumeChooserTest.java:[line 120]Another occurrence at
SpaceAwareVolumeChooserTest.java:[line 121] ICAST_IDIV_CAST_TO_DOUBLE
- [ERROR] Medium: Integral division result cast to double or float in
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest.testEvenWeightsWithCaching()
[org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest,
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest] At
SpaceAwareVolumeChooserTest.java:[line 108]Another occurrence at
SpaceAwareVolumeChooserTest.java:[line 109] ICAST_IDIV_CAST_TO_DOUBLE
- [ERROR] Medium: Integral division result cast to double or float in
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest.testNinetyTen()
[org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest,
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest] At
SpaceAwareVolumeChooserTest.java:[line 138]Another occurrence at
SpaceAwareVolumeChooserTest.java:[line 139] ICAST_IDIV_CAST_TO_DOUBLE
- [ERROR] Medium: Integral division result cast to double or float in
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest.testTenNinety()
[org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest,
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest] At
SpaceAwareVolumeChooserTest.java:[line 150]Another occurrence at
SpaceAwareVolumeChooserTest.java:[line 151] ICAST_IDIV_CAST_TO_DOUBLE
- [ERROR] Medium: Integral division result cast to double or float in
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest.testWithNoCaching()
[org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest,
org.apache.accumulo.core.spi.fs.SpaceAwareVolumeChooserTest] At
SpaceAwareVolumeChooserTest.java:[line 162]Another occurrence at
SpaceAwareVolumeChooserTest.java:[line 163] ICAST_IDIV_CAST_TO_DOUBLE
- [ERROR] Medium:
org.apache.accumulo.core.util.LocalityGroupUtil$PartitionedMutation.equals(Object)
is unusual
[org.apache.accumulo.core.util.LocalityGroupUtil$PartitionedMutation] At
LocalityGroupUtil.java:[line 278] EQ_UNUSUAL
- [ERROR] Medium: Return value of PreAllocatedArray.get(int) ignored, but
method has no side effect [org.apache.accumulo.core.util.PreAllocatedArrayTest]
At PreAllocatedArrayTest.java:[line 101] RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
- [ERROR] Medium: Return value of PreAllocatedArray.get(int) ignored, but
method has no side effect [org.apache.accumulo.core.util.PreAllocatedArrayTest]
At PreAllocatedArrayTest.java:[line 108] RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
- [ERROR] Medium: Return value of PreAllocatedArray.get(int) ignored, but
method has no side effect [org.apache.accumulo.core.util.PreAllocatedArrayTest]
At PreAllocatedArrayTest.java:[line 100] RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
- [ERROR] Medium: Return value of PreAllocatedArray.get(int) ignored, but
method has no side effect [org.apache.accumulo.core.util.PreAllocatedArrayTest]
At PreAllocatedArrayTest.java:[line 107] RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
- [ERROR] Medium: Exception is caught when Exception is not thrown in
org.apache.accumulo.fate.ZooStore.reserve() [org.apache.accumulo.fate.ZooStore]
At ZooStore.java:[line 211] REC_CATCH_EXCEPTION
- [ERROR] Medium: Return value of Retry.canRetry() ignored, but method has
no side effect [org.apache.accumulo.fate.util.RetryTest] At
RetryTest.java:[line 84] RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
