cshannon commented on PR #2925:
URL: https://github.com/apache/accumulo/pull/2925#issuecomment-1248581056

   > > Found another utility that can be moved to the accumulo admin command. 
This utility cleans all old instances out of Zookeeper (except the current 
one). It's a bit different than the DeleteZooInstance command as that command 
allows deleting a single instance that is specified so it's worth having both.
   > 
   > I'm not sure it's worth having both. The delete one could just have a flag 
to delete all non-current ones.
   
   I like that idea, I can simply move this functionality to the other command 
pretty easily and have a flag as you suggested. Having 1 utility/command to 
clean up zookeeper instances is probably less confusing and I can just update 
the troubleshooting documentation.
   
   If no one else has any other comments or objects I can create a new PR 
tomorrow (and close this one) that moves the functionality here into the other 
utility and then removes the CleanZookeeper utility as it won't be needed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to