keith-turner commented on code in PR #2967:
URL: https://github.com/apache/accumulo/pull/2967#discussion_r981592709
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1035,6 +1031,30 @@ public void modifyProperties(String tableName, final
Consumer<Map<String,String>
}
}
+ @Override
+ public void modifyProperties(String tableName, final
Consumer<Map<String,String>> mapMutator)
+ throws AccumuloException, AccumuloSecurityException,
IllegalArgumentException {
+ EXISTING_TABLE_NAME.validate(tableName);
+ checkArgument(mapMutator != null, "mapMutator is null");
+
+ Retry retry =
+ Retry.builder().infiniteRetries().retryAfter(25,
MILLISECONDS).incrementBy(25, MILLISECONDS)
+ .maxWait(30, SECONDS).backOffFactor(1.5).logInterval(3,
MINUTES).createRetry();
+
Review Comment:
Good question. I copied and pasted that code and modified it a bit. I went
a looked at the code and logging does not happen unless an explicit method call
is made. I need to look into this some more, see if I should call the logging
method or remove the config from the builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
