dlmarion commented on code in PR #2990: URL: https://github.com/apache/accumulo/pull/2990#discussion_r984821954
########## server/manager/src/main/java/org/apache/accumulo/manager/Manager.java: ########## @@ -207,7 +208,7 @@ public class Manager extends AbstractServer private ManagerState state = ManagerState.INITIAL; - Fate<Manager> fate; + private final AtomicReference<Fate<Manager>> fateReady = new AtomicReference<>(null); Review Comment: I was suggesting using both: ``` private final AtomicReference<Fate<Manager>> fateReady = new AtomicReference<>(null); private final CountDownLatch fateLatch = new CountDownLatch(1); ``` You don't need to make `fateReady` volatile, as AtomicReference.get() and set() already have the memory semantics of volatile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
