EdColeman commented on code in PR #3003:
URL: https://github.com/apache/accumulo/pull/3003#discussion_r996928518
##########
server/base/src/main/java/org/apache/accumulo/server/conf/util/ConfigTransformer.java:
##########
@@ -152,18 +152,15 @@ VersionedProperties transform(final PropStoreKey<?>
propStoreKey, final Transfor
}
}
- Set<LegacyPropNode> upgradeNodes = readLegacyProps(propStoreKey);
- if (upgradeNodes == null) {
- log.info("Found existing node after reading legacy props {}, skipping
conversion",
+ Set<LegacyPropNode> upgradeNodes = readLegacyProps(legacyPath);
+ if (upgradeNodes.size() == 0) {
+ log.trace("No existing legacy props {}, skipping conversion, writing
default prop node",
propStoreKey);
- results = ZooPropStore.readFromZk(propStoreKey, propStoreWatcher, zrw);
- if (results != null) {
- return results;
- }
+ return writeNode(propStoreKey, Map.of());
}
upgradeNodes = convertDeprecatedProps(propStoreKey, upgradeNodes);
-
+ // todo - here
Review Comment:
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
