DomGarguilo commented on code in PR #3026:
URL: https://github.com/apache/accumulo/pull/3026#discussion_r997499181
##########
core/src/main/java/org/apache/accumulo/fate/util/Retry.java:
##########
@@ -176,14 +174,14 @@ public long retriesCompleted() {
return retriesDone;
}
- public void waitForNextAttempt() throws InterruptedException {
+ public void waitForNextAttempt(Logger log, String operationDesc) throws
InterruptedException {
Review Comment:
I wonder if having the method signature as
`waitForNextAttempt(Consumer<String> log, String operationDesc)` would be of
use here so that way you could specify the log level. Something like:
`waitForNextAttempt(log::debug, "About to retry!")` or somehow wrapping the
logging of the message into a single functional variable that is passed into
`waitForNextAttempt()` as its only parameter. Haven't looked into this much but
just putting some ideas out in case they could lead to improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
