ctubbsii commented on code in PR #103:
URL: https://github.com/apache/accumulo-examples/pull/103#discussion_r999529191


##########
pom.xml:
##########
@@ -100,7 +100,7 @@
     </dependency>
     <dependency>
       <groupId>org.apache.logging.log4j</groupId>
-      <artifactId>log4j-slf4j-impl</artifactId>
+      <artifactId>log4j-slf4j2-impl</artifactId>

Review Comment:
   > It looks like it already is on main:
   > 
   > 
https://github.com/apache/accumulo-examples/blob/516163f3ddadc87f9ffdca61afe08458c61055c2/pom.xml#L96-L100
   > 
   > Is this what you mean or am I misunderstanding?
   
   Oh, interesting. It looks like @jmark99 added it in 
ce94cbb3956164742273090d0cec8b5814ff41cc . It probably wasn't needed before. I 
assumed it was absent, but if it's already there, then there's nothing extra to 
do here for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to