keith-turner commented on code in PR #3063:
URL: https://github.com/apache/accumulo/pull/3063#discussion_r1011874115
##########
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/CachedBlockQueue.java:
##########
@@ -73,7 +73,7 @@ public void add(CachedBlock cb) {
heapSize += cb.heapSize();
} else {
CachedBlock head = queue.peek();
- if (cb.compareTo(head) > 0) {
+ if (head != null && cb.compareTo(head) > 0) {
Review Comment:
I suspect the code was written with the assumption that when in the else
that there is always something in the queue and peek will not return null. So
maybe instead of ignoring null, could throw an assertionerror or illegal state
exception when seeing null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
