ctubbsii opened a new issue, #3072: URL: https://github.com/apache/accumulo/issues/3072
While reviewing #2861, I noticed that the `more` field wasn't really used for much. It was just used for one additional lookup. However, the value of `more` was never assigned again. It looked like this was originally supposed to be part of a loop and the `more` value being true kept it in the loop. However, looking at this code further, I can't tell what any of it is doing. It looks like the `if` should be a `while` loop, but this is not clear. Perhaps only one additional lookup needs to be done if `more` is true, but there are no comments explaining why this would be the case, and it's not obvious to me. Some comments in here would be really nice, and if there is a bug and this should be a loop, that should be fixed. https://github.com/apache/accumulo/blob/6d3aeccd8e86853bb8cf88b7590673787e127d0a/core/src/main/java/org/apache/accumulo/core/metadata/MetadataLocationObtainer.java#L114-L123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
