ctubbsii commented on code in PR #3073: URL: https://github.com/apache/accumulo/pull/3073#discussion_r1017306674
########## core/src/main/java/org/apache/accumulo/core/client/AccumuloClient.java: ########## @@ -52,7 +52,7 @@ * * <p> * If migrating code from Connector to AccumuloClient an important difference to consider is that - * AccumuloClient is closable and Connector is not. Connector uses static resources and therefore + * AccumuloClient is closable and Connector was not. Connector uses static resources and therefore * creating them is cheap. AccumuloClient attempts to clean up resources on close, so constantly Review Comment: Addressed in 49dd2789c4 ########## core/src/main/java/org/apache/accumulo/core/client/AccumuloClient.java: ########## @@ -52,7 +52,7 @@ * * <p> * If migrating code from Connector to AccumuloClient an important difference to consider is that - * AccumuloClient is closable and Connector is not. Connector uses static resources and therefore + * AccumuloClient is closable and Connector was not. Connector uses static resources and therefore * creating them is cheap. AccumuloClient attempts to clean up resources on close, so constantly * creating them could perform worse than Connector. Therefore, it would be better to create an Review Comment: Addressed in 49dd2789c4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
